Fix B103: Support stat constants and BitOr operations in os.chmod#1391
Closed
9iang22 wants to merge 1 commit into
Closed
Fix B103: Support stat constants and BitOr operations in os.chmod#13919iang22 wants to merge 1 commit into
9iang22 wants to merge 1 commit into
Conversation
Adds AST mode resolution for os.chmod to prevent false negatives, along with updated test cases.
9iang22
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix B103 false negatives for stat-based chmod modes
B103 relied on literal mode extraction and missed chmod calls where permissions were expressed as stat constants or BitOr combinations. That created false negatives for dangerous permission settings written in common, idiomatic Python forms.
This change resolves mode values from the AST for integer constants, stat.* attributes, and
|combinations so existing B103 checks apply consistently across equivalent expressions.It also updates the chmod functional example and expected counts to cover the newly detected unsafe cases.
Resolves: #1390